On Dec 5, 2007 11:31 AM, Kevin Fenzi <[EMAIL PROTECTED]> wrote: > Greetings. > > I submitted a while ago a review request for a new spec for clamav in > EPEL. So far I haven't gotten any reviewers interested in it... > > https://bugzilla.redhat.com/show_bug.cgi?id=396171 > > If anyone would like to review it that would be great. > > I would be happy to also trade reviews. > > It would be nice to get this in so EPEL has a nice new up to date and authorize> working clamav. >
Ok... my opinions aren't going to be the greatest as I am really out of practice.. but here are some general questions 1) Is massive perl patches ok for Fedora packages or is it better to generate the patch as a file and apply it directly. When I do it myself, I prefer the second as it doesnt break my auto-buildsystem as much as pulling in perl etc when I don't need it. 2) file creation from inside of the SPEC. Is it better to have them as seperate files or use cat inside the SPEC? Again.. I prefer seperate files.. but I can understand having it in the spec means fix once versus remember to fix a file you forgot about. 3) The generation of the UID is using whatever useradd gives it. Does this fit in with the Fedora/EPEL standards? -- Stephen J Smoogen. -- CSIRT/Linux System Administrator How far that little candle throws his beams! So shines a good deed in a naughty world. = Shakespeare. "The Merchant of Venice" _______________________________________________ epel-devel-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/epel-devel-list
