On Fri, Jun 17, 2022 at 1:41 PM Troy Dawson <tdaw...@redhat.com> wrote:
> > > On Fri, Jun 17, 2022 at 1:20 PM Carl George <c...@redhat.com> wrote: > >> On Fri, Jun 17, 2022 at 8:33 AM Troy Dawson <tdaw...@redhat.com> wrote: >> > >> > >> > >> > On Thu, Jun 16, 2022 at 10:22 PM Carl George <c...@redhat.com> wrote: >> >> >> >> On Wed, Jun 15, 2022 at 5:12 PM Troy Dawson <tdaw...@redhat.com> >> wrote: >> >> > >> >> > I'm totally top-posting, and I apologize for that. >> >> > >> >> > For right now, I'm going to put my enable-crb script in >> epel-release, but not automatically run it in a %post script or anything. >> >> > The debate about putting it in a post script, or a separate package, >> can go on independently of the script. >> >> > >> >> > This does a few things. >> >> > - give people a single, easy to remember way to enable crb >> >> > -- Right now if you install anything but RHEL you might remember >> "dnf install epel-release" but then you forget what the dnf command is to >> enable a repo, and you might forget if it's crb or powertools. >> >> > -- It will make scripting easier because you just have one command >> that will work across all RHEL compatibles. >> >> > >> >> > - gives the script a chance to find all the corner cases >> >> > -- It's worked on everything I've tried thus far, but I'm sure there >> are some corner cases or two where the script doesn't work. >> >> > >> >> > I was thinking of it being >> >> > /usr/bin/enable-crb >> >> > /usr/bin/epel-enable-crb (a link to enable-crb) >> >> > >> >> > Thoughts? >> >> > >> >> > Troy >> >> > >> >> I think it would be nice to be able to both enable and disable from >> >> the same script. This would come in handy when you are looking for >> >> things that don't install when crb is disabled. I don't see anything >> >> else in Fedora or RHEL that ships a command with the name crb, so how >> >> about that? >> >> >> >> crb enable >> >> crb disable >> > >> > >> > That shouldn't be too hard. I'm going to give it a shot. >> > If that takes too long, I'll just push what I currently have for now. >> > >> > I notice that you said crb-enable, crb-disable. >> > Do you like having the name first, or the function first? >> > >> > enable-crb vs crb-enable ? >> > >> > either way I want to have it by itself, as well as starting with epel >> > >> > epel-enable-crb vs epel-crb-enable ? >> > >> > Troy >> > >> I was specifically suggesting /usr/bin/crb, accepting a single >> argument of enable or disable. I can't find anything else in Fedora >> or RHEL using that path. >> >> What would be the purpose of prefixing it with "epel-"? It's not "CRB >> from EPEL", it's a generic script for enabling/disabling the crb repo >> that just happens to be included in the epel-release package. >> > > crb is as good as anything else. > I'll use that, with options. > > Troy > Pull request has been updated. https://src.fedoraproject.org/rpms/epel-release/pull-request/21 The script is now called /usr/bin/crb The script can enable, disable and give the status of the crb repo. This script is NOT run during epel-release install. %post gives a recommendation to run the script. The script has been tested on virtual machines for rhel8, rhel9, alma8, alma9, cs8 and cs9. The test enabled, disabled, and gave statuses. Works pretty good with everything I've tested. Let me know what ya'll think. Troy
_______________________________________________ epel-devel mailing list -- epel-devel@lists.fedoraproject.org To unsubscribe send an email to epel-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/epel-devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
