> If they are tested and fixed I don't see why you shouldn't push them
> to the canonical.
I'm quickchecking it, and found another bug. I'll push whenever I
finish decoding.
There is, however, one thing that makes me need a kind of incompatible
change. I must be able to recover a term after encoding it, but right
now, an empty array and an empty string decode to the same term: [] so
it is impossible to recover the original term once you encoded it to
JSON.
The solution I like is decoding strings as binaries. It's nice, also,
because ktj_encode expect strings to be binaries. The change is
straightforward, but breaks backwards compatibility. What's your idea
about that?
--- a/src/ktuo_parse_utils.erl
+++ b/src/ktuo_parse_utils.erl
@@ -78,7 +78,7 @@ stringish_body(Delim, [$\n | T], Acc, NewLines, _Chars) ->
stringish_body(Delim, [$\r | T], Acc, NewLines, _Chars) ->
stringish_body(Delim, T, [$\r | Acc], NewLines + 1, 0);
stringish_body(Delim, [Delim | T], Acc, NewLines, Chars) ->
- {lists:reverse(Acc), T, {NewLines, Chars + 1}};
+ {list_to_binary(lists:reverse(Acc)), T, {NewLines, Chars + 1}};
stringish_body(Delim, [H | T], Acc, NewLines, Chars) ->
stringish_body(Delim, T, [H | Acc], NewLines, Chars + 1);
stringish_body(_Delim, [], _Acc, NewLines, Chars) ->
Cheers
>
> Eric
>
> On Sat, Aug 28, 2010 at 2:19 PM, Samuel <[email protected]> wrote:
>> Hi,
>>
>> Way ago I opened an issue in ktuo, it has a bug encoding slashes:
>> http://code.google.com/p/ktuo/issues/detail?id=3
>>
>> I forget about that and it hit me again after cloning from erlware/ktuo.
>>
>> it is tested and fixed in my clon:
>> git://github.com/samuelrivas/ktuo.git branch issue-3. Should I push it
>> to the official repository? ;)
>>
>> Cheers
>> --
>> Samuel
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "erlware-dev" group.
>> To post to this group, send email to [email protected].
>> To unsubscribe from this group, send email to
>> [email protected].
>> For more options, visit this group at
>> http://groups.google.com/group/erlware-dev?hl=en.
>>
>>
>
> --
> You received this message because you are subscribed to the Google Groups
> "erlware-dev" group.
> To post to this group, send email to [email protected].
> To unsubscribe from this group, send email to
> [email protected].
> For more options, visit this group at
> http://groups.google.com/group/erlware-dev?hl=en.
>
>
--
Samuel
--
You received this message because you are subscribed to the Google Groups
"erlware-dev" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/erlware-dev?hl=en.
