Samuel,
I have pulled and tested. I am getting a consistant failure in config
test of ktuo parse.
ktj_parse:ktj_parse: config_test...*failed*
::error:{assertMatch_failed,
[{module,ktj_parse},
{line,324},
{expression,"Value"},
{expected,
"{ obj , [ { << "build" >> , { obj , [ { << "start_dir"
>> , << "/home/something/workspace/sinan/client" >> } ] } } ] }"},
{value,{obj,[{"build",{obj,[{"start_dir",[...]}]}}]}}]}
in function ktj_parse:'-config_test/0-fun-0-'/1
=======================================================
Failed: 1. Skipped: 0. Passed: 4.
Maybe you forgot to commit something?
On Tue, Sep 14, 2010 at 9:33 AM, Eric Merritt <[email protected]> wrote:
> ok samuel this sounds good. I will get it reviewed and pulled into
> canonical. Thanks for all the work!
>
> On Tue, Sep 14, 2010 at 1:29 AM, Samuel <[email protected]> wrote:
>> Ok I reorganised it a bit,
>>
>> * I sorted the commits so that up to tag 0.4-fixes, the API is still
>> the same, but the bug with escapes and the bug with negative reals are
>> fixed. This would be the HEAD for former API branch (i.e. next version
>> compatible with 0.4.0.1)
>> * I added a testcase for negative reals
>> * I then applied the incompatible change
>> * Copied ktj_decode to ktj_parse and changed the decode function to parse
>>
>> So next branch's HEAD is new API version, decoding binaries as strings.
>>
>> You should have a pull request for that. Forget about my former pull
>> request, since my next branch has diverged, so the one you have is
>> invalid.
>>
>> I discovered that I broke ktt_decode, since I'm not using it and I
>> didn't run its tests until now. I reran all my foreign tests and all
>> still pass, so I'm pretty confident I didn't borke anything in
>> ktj_parse or in ktj_encode.
>>
>> Cheers
>> --
>> Samuel
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "erlware-dev" group.
>> To post to this group, send email to [email protected].
>> To unsubscribe from this group, send email to
>> [email protected].
>> For more options, visit this group at
>> http://groups.google.com/group/erlware-dev?hl=en.
>>
>>
>
--
You received this message because you are subscribed to the Google Groups
"erlware-dev" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/erlware-dev?hl=en.
