We actually do have a formal peer review process in erlware that we follow pretty rigorously, and thats not going to change with this suggestion. Basically, none of us are allowed to commit our own code to canonical, it has to go through a third party who will commit (what you do in your own repo is your business of course). No one is really aware of that because its just been martin, me, jordan and tristan who have been doing the vast majority of the work and we have tended to email and pass things around directly between us. There has actually been a ton of active development that is completely hidden from anyone outside of the four of us. Thats something I am trying to change, though and this is one of the ways I am doing that.
The review process has generated a ton of actual useful discussion as well, but again its been entirely off list between the two participants, which denies others the ability to participate and hides potentially valuable information that could be useful in the future. On Thu, Jul 14, 2011 at 1:47 PM, Samuel <[email protected]> wrote: > I'm more with Martin here. Patches in the list could be a win when > most of the readers are participating actively in the development > related to those patches. When they are not, though, I don't think > patches will lead people to cooperate more. In that case my guess is > that most of them will just /dev/null them. As you say is not a lot of > effort to set a filter for that, so trying is not that expensive > anyway. > > I think a better approach is setting a formal peer review mechanism > with some tooling, as the webkit people do with their commit queue and > patch review policies. That could help better to spread the changes > and style among the contributors. > > Best > > On 14 July 2011 18:59, Eric Merritt <[email protected]> wrote: >> Thats exactly it Salomon, >> >> The upside is high, while the downside is very small and easily >> negated. Its a win all around. >> >> On Thu, Jul 14, 2011 at 11:54 AM, Salomon Elizondo <[email protected]> >> wrote: >>> I think Eric's hidden desire is for others to participate (code >>> review, contribute, etc). Although I agree with Martin's points about >>> having a "right channel" for this, publishing to this mailing list >>> would at least increase activity, which is good. Can always stop if it >>> becomes a "problem". >>> >>> Salomon >>> >>> On Wed, Jul 13, 2011 at 11:12 PM, Martin Logan <[email protected]> >>> wrote: >>>> You are not the audience :) You are excited about sending your >>>> patches out. There are a few people that want to see your patches, but >>>> the majority don't have plans to develop directly in sinan, and even >>>> if they did, the patches coming out require a lot of work to gain >>>> appropriate context on. >>>> >>>> >>>> On Wed, Jul 13, 2011 at 2:39 PM, Eric Merritt <[email protected]> >>>> wrote: >>>>> Just a follow up. We have done this in the past. Back in 2008, we >>>>> where sending patches to the list. I was looking at the archive today >>>>> and the patches seemed to stimulate a lot of discussions and we seem >>>>> to have gotten a ton more patches then we do now. I would like to see >>>>> that happen again. The list is dead at the moment and though a ton of >>>>> development is going on across several projects thats not apparent. >>>>> Thats not the purpose of sending the patches to the list, the purpose >>>>> is publishing change. However, it is a very nice side benefit and its >>>>> something that I see happen in any organization that uses this >>>>> approach. >>>>> >>>>> On Wed, Jul 13, 2011 at 2:32 PM, Eric Merritt <[email protected]> >>>>> wrote: >>>>>> I disagree, of course, its not spam. And it is very contextually >>>>>> relevant to the erlware-dev list. Though I wouldn't suggest it for the >>>>>> erlware-questions. I am assuming here that the folks on erlware-dev >>>>>> are either participating in or interested in erlware development. That >>>>>> given I can't imagine how change to the code base, or change that >>>>>> people are submitting to the code base isn't relevant. And for those >>>>>> folks that want to be on the dev list, but not really interested in >>>>>> development, the subjects are tagged and hence they can get out of it >>>>>> fairly easily. >>>>>> >>>>>> I am not a big fan of a seperate list, it defeats the purpose. >>>>>> >>>>>> On Wed, Jul 13, 2011 at 2:23 PM, Martin Logan <[email protected]> >>>>>> wrote: >>>>>>> I am not a fan of it. It turns the dev-list into a spam list. The >>>>>>> patches are not contextual enough for most people on the list to get >>>>>>> value out of and therefore are not useful to the majority of folks. We >>>>>>> have a separate list for that sort of commication that I think people >>>>>>> can sign up for if they want to see this traffic. >>>>>>> >>>>>>> On Wed, Jul 13, 2011 at 12:03 PM, Eric Merritt <[email protected]> >>>>>>> wrote: >>>>>>>> Guys, >>>>>>>> >>>>>>>> I am a big fan of patches going to the dev mailing list, in the style >>>>>>>> of the git mailing list or the kernel. I think its a great way to >>>>>>>> interact with the community and peers. I do this at in my professional >>>>>>>> life and want to get back to it with open source projects. So I am >>>>>>>> seriously considering moving back to pushing these through the this >>>>>>>> mailing list. For those of you not wanting to receive them, each >>>>>>>> commit email will have a tagged subject line in the form of >>>>>>>> [*project-name* PATCH] and so should be easy to send off into your >>>>>>>> bulk mail folder or trash. I figured I would poll the community, and >>>>>>>> if people didn't explode startup with the next set of public patches >>>>>>>> to one of the erlware projects. >>>>>>>> >>>>>>>> Eric >>>>>>>> >>>>>>>> -- >>>>>>>> You received this message because you are subscribed to the Google >>>>>>>> Groups "erlware-dev" group. >>>>>>>> To post to this group, send email to [email protected]. >>>>>>>> To unsubscribe from this group, send email to >>>>>>>> [email protected]. >>>>>>>> For more options, visit this group at >>>>>>>> http://groups.google.com/group/erlware-dev?hl=en. >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Martin Logan >>>>>>> Erlang & OTP in Action (Manning) http://manning.com/logan >>>>>>> http://twitter.com/martinjlogan >>>>>>> http://erlware.org >>>>>>> >>>>>>> -- >>>>>>> You received this message because you are subscribed to the Google >>>>>>> Groups "erlware-dev" group. >>>>>>> To post to this group, send email to [email protected]. >>>>>>> To unsubscribe from this group, send email to >>>>>>> [email protected]. >>>>>>> For more options, visit this group at >>>>>>> http://groups.google.com/group/erlware-dev?hl=en. >>>>>>> >>>>>>> >>>>>> >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google Groups >>>>> "erlware-dev" group. >>>>> To post to this group, send email to [email protected]. >>>>> To unsubscribe from this group, send email to >>>>> [email protected]. >>>>> For more options, visit this group at >>>>> http://groups.google.com/group/erlware-dev?hl=en. >>>>> >>>>> >>>> >>>> >>>> >>>> -- >>>> Martin Logan >>>> Erlang & OTP in Action (Manning) http://manning.com/logan >>>> http://twitter.com/martinjlogan >>>> http://erlware.org >>>> >>>> -- >>>> You received this message because you are subscribed to the Google Groups >>>> "erlware-dev" group. >>>> To post to this group, send email to [email protected]. >>>> To unsubscribe from this group, send email to >>>> [email protected]. >>>> For more options, visit this group at >>>> http://groups.google.com/group/erlware-dev?hl=en. >>>> >>>> >>> >>> -- >>> You received this message because you are subscribed to the Google Groups >>> "erlware-dev" group. >>> To post to this group, send email to [email protected]. >>> To unsubscribe from this group, send email to >>> [email protected]. >>> For more options, visit this group at >>> http://groups.google.com/group/erlware-dev?hl=en. >>> >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "erlware-dev" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]. >> For more options, visit this group at >> http://groups.google.com/group/erlware-dev?hl=en. >> >> > > > > -- > Samuel > > -- > You received this message because you are subscribed to the Google Groups > "erlware-dev" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/erlware-dev?hl=en. > > -- You received this message because you are subscribed to the Google Groups "erlware-dev" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/erlware-dev?hl=en.
