On Tue, Jul 8, 2014 at 1:40 AM, Dmitry Soshnikov <[email protected] > wrote:
> On Sun, Jul 6, 2014 at 10:36 PM, Isiah Meadows <[email protected]> > wrote: > >> My responses are inline. >> >> > From: Alex Kocharin <[email protected]> >> > To: Oliver Hunt <[email protected]>, Dmitry Soshnikov < >> [email protected]> >> > Cc: es-discuss <[email protected]> >> > Date: Sun, 06 Jul 2014 12:07:09 +0400 >> > Subject: Re: Trailing comma for function arguments and call parameters >> >> > >> > In fact, how about the same syntax for arrays and function calls? With >> trailing commas and elisions? >> > >> > So foo(1,,3,,) would be an alias for foo(1,undefined,3,undefined) ? >> > >> > >> > 06.07.2014, 11:57, "Alex Kocharin" <[email protected]>: >> > > Unless you use leading comma style, trailing commas are very good to >> have for anything that has variable amount of items/keys/arguments. >> > > >> > > This is a classic example I use to show why JSON is a bad idea: >> https://github.com/npm/npm/commit/20439b21e103f6c1e8dcf2938ebaffce394bf23d#diff-6 >> > > >> > > I believe the same thing applies for javascript functions. If it was >> a bug in javascript, I wish for more such bugs really... >> > > >> > > 04.07.2014, 20:33, "Oliver Hunt" <[email protected]>: >> > >> On Jul 3, 2014, at 3:52 PM, Dmitry Soshnikov < >> [email protected]> wrote: >> > >>> Hi, >> > >>> >> > >>> Will it makes sense to standardize a trailing comma for function >> arguments, and call parameters? >> >> 2. Function statements usually don't have such long lists of arguments >> that such a thing would truly become useful. That is rare even in C, where >> you may have as many as 6 or 7 arguments for one function. >> > > Yes, it's true, however, my use-case was based on 80-cols rule we use in > our code-base. And with type annotations (especially type annotations with > generics, when you have types like `Map<string, IParamDefinition> $params`, > etc) it can quickly become more than 80 cols, and our style-guide is to use > each parameter on its own line, with a trailing comma for convenience of > future adding that will preserve git blame logs if one doesn't need always > append the comma on previous line, in case when adding a new parameter > Another example can be found by looking at pretty much any Angular-based codebase, due to the dependency injection. +1 from me for this. Anything that makes changesets easier to contain makes me happier. I also think it'd be a nice for syntax consistency to support this. Cheers, Jussi > > Dmitry > > _______________________________________________ > es-discuss mailing list > [email protected] > https://mail.mozilla.org/listinfo/es-discuss > >
_______________________________________________ es-discuss mailing list [email protected] https://mail.mozilla.org/listinfo/es-discuss
