That's correct. That branch has all of the unittests I converted so far. Jake mocha command outputs report in dot-matrix format because Jake screws with the output, and all the rest of the reporters are unreadable. However, I just pushed a new checkin to convert us from Jake to Grunt. grunt mocha command will output everything in spec format, and will run coverage report as well.
Thanks, Ilya Volodin On Friday, November 15, 2013 1:37:54 PM UTC-5, michael paulukonis wrote: > And to clarify futher -- these are the tests you have converted so far? > > https://github.com/ilyavolodin/eslint/tree/Unittest/tests/mocha/lib/rules > > and "jake mocha" runs the new tests, and only outputs dots (".") for > successes? > > 'cause the output I got was > > eslint>jake mocha > > ....................................................... > ........................................................ > ........................................................ > .......... > > eslint> > > -Michael Paulukonis > http://www.xradiograph.com > <http://goog_2112721603>Interference Patterns (a > blog)<http://www.xradiograph.com%5Cinterference> > @XraysMonaLisa <https://twitter.com/XraysMonaLisa> > http://michaelpaulukonis.com > <http://www.BestAndroidResources.com> > > Sent from somewhere in the Cloud > (hearthrug, by the fender) > > > On Fri, Nov 15, 2013 at 11:42 AM, Ilya Volodin <[email protected]<javascript:> > > wrote: > >> Michael, yes, I meant the list of test for rules and I think >> wrap-regex.js is the last one (alphabetically sorted). Sorry for confusion. >> >> Thanks, >> >> Ilya Volodin >> >> On Fri, Nov 15, 2013 at 10:10 AM, michael paulukonis >> <[email protected]<javascript:> >> > wrote: >> >>> Ilya - I just volunteered to help out on github: >>> https://github.com/nzakas/eslint/pull/341#issuecomment-28573827 where >>> you said "Maybe you can start from the bottom of the list, while I'm going >>> from the top?" >>> >>> By list, do you mean >>> https://github.com/nzakas/eslint/tree/master/tests/lib/rules where >>> "bottom of the list" would be >>> "wrap-regex.js<https://github.com/nzakas/eslint/blob/master/tests/lib/rules/wrap-regex.js>" >>> >>> ? >>> >>> >>> >>> >>> On Sunday, November 10, 2013 4:07:12 PM UTC-5, Ilya Volodin wrote: >>>> >>>> I'm converting a few unittests per day to new format (all I have time >>>> for now a days) that is built on top of Mocha, and I'm finding a bunch of >>>> issues in the existing unittests. Most of the people just copy and paste >>>> existing structure into a new file and then modify it (I'm guilty of it as >>>> much as anyone else). However, not in all cases "should report a >>>> violation" >>>> was adjusted to specific test. So we have a bunch of tests that are saying >>>> that they should report a violation, when they are actually not reporting >>>> any. Also, I found at least 2 examples so far, when multiple tests where >>>> named the same way. Vows just overrides them, since it keeps them in the >>>> dictionary, with name being key. >>>> >>>> Just something to watch out for in the future. I'm fixing those tests >>>> as I find them. >>>> >>>> Thanks, >>>> >>>> Ilya Volodin >>>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "ESLint" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected] <javascript:>. >>> For more options, visit https://groups.google.com/groups/opt_out. >>> >> >> > -- You received this message because you are subscribed to the Google Groups "ESLint" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
