All mocha tests have been merged into master eslint branch. So you should be
able to create a pull request into https://github.com/nzakas/eslint. I also
created a ticket to track all of the conversions, once you create a pull
request, you should mark those two rules as converted here:
https://github.com/nzakas/eslint/issues/397.
Thanks for your help!
Ilya Volodin
From: michael paulukonis [mailto:[email protected]]
Sent: Wednesday, November 20, 2013 11:21 PM
To: Ilya Volodin
Cc: [email protected]
Subject: Re: [ESLint] Re: Unittests
Thanks, Ilya.
I've created mocha-conversion for semi.js and wrap-regex.js over @
https://github.com/MichaelPaulukonis/eslint/commit/b5e8d051d4c68c24d78bf117a
69e9dd8ebe2f134
If these are good, how should I be pushing them around? To your fork, or
what?
-Michael Paulukonis
http://www.xradiograph.com
Interference Patterns (a blog) <http://www.xradiograph.com%5Cinterference>
@XraysMonaLisa <https://twitter.com/XraysMonaLisa>
http://michaelpaulukonis.com
Sent from somewhere in the Cloud
(hearthrug, by the fender)
On Tue, Nov 19, 2013 at 3:23 PM, Ilya Volodin <[email protected]> wrote:
I just updated a pull request on the eslint with comments for eslintTester
which has explanation about the formatting that should be used to write new
tests. Also, the only way right now to run individual tests is to install
mocha globally (npm install -g mocha) and then run tests on individual files
(mocha tests/mocha/lib/rules/yourfilename.js). As far as I know, grunt
doesn't support arbitrary command line parameters, so I don't think there's
a way to do it through grunt. If you REALLY don't want to install mocha
globally, then you can always call local version from node_packages.
While vows tests might've been easier to understand, they also took
significantly longer to write (just because you had to repeat yourself all
the time). That's what we are trying to fix. I think once you read the
comments in eslintTester and look at the few tests that I already converted,
it should be pretty clear how to do it.
Thanks,
Ilya Volodin
From: michael paulukonis [mailto:[email protected]]
Sent: Tuesday, November 19, 2013 3:14 PM
To: Ilya Volodin; [email protected]
Subject: Re: [ESLint] Re: Unittests
Ilya - I've been poking through the tests and making notes.
Your new wrapper isn't as clear to me as the old vows-based tests were; I
grokked those pretty quickly, and was writing my own tests within minutes.
[I'm not critiquing your wrapper; I just don't understand it fully.]
I've looked at these several times and I haven't been able to write anything
from scratch.
Part of my problem stems from testing -- how can I run an individual mocha
test?
"grunt mocha" runs the entire suite.
to run an individual test.. there isn't a way right now? It would have to be
added to the grunt-mocha-test gruntfile and the main gruntfile?
I'm also a newbie to grunt, so that's in the way, as well.
-Michael Paulukonis
http://www.xradiograph.com
Interference Patterns (a blog) <http://www.xradiograph.com%5Cinterference>
@XraysMonaLisa <https://twitter.com/XraysMonaLisa>
http://michaelpaulukonis.com
Sent from somewhere in the Cloud
(hearthrug, by the fender)
On Mon, Nov 18, 2013 at 8:52 AM, michael paulukonis
<[email protected]> wrote:
Thanks, Ilya. I wasn't able to get any further this weekend due to a house
full of head-colds.
I hope to make some headway today.
-Michael Paulukonis
http://www.xradiograph.com
Interference Patterns (a blog) <http://www.xradiograph.com%5Cinterference>
@XraysMonaLisa <https://twitter.com/XraysMonaLisa>
http://michaelpaulukonis.com
Sent from somewhere in the Cloud
(hearthrug, by the fender)
On Sat, Nov 16, 2013 at 8:22 PM, Ilya Volodin <[email protected]> wrote:
That's correct. That branch has all of the unittests I converted so far.
Jake mocha command outputs report in dot-matrix format because Jake screws
with the output, and all the rest of the reporters are unreadable. However,
I just pushed a new checkin to convert us from Jake to Grunt. grunt mocha
command will output everything in spec format, and will run coverage report
as well.
Thanks,
Ilya Volodin
On Friday, November 15, 2013 1:37:54 PM UTC-5, michael paulukonis wrote:
And to clarify futher -- these are the tests you have converted so far?
https://github.com/ilyavolodin/eslint/tree/Unittest/tests/mocha/lib/rules
and "jake mocha" runs the new tests, and only outputs dots (".") for
successes?
--
You received this message because you are subscribed to the Google Groups
"ESLint" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
