Friday, July 4th, 2014, 21:32:02 UTC+2 skrev Nicholas Zakas: > > Hi Petter, > > I just checked out master and I'm not seeing this problem. It's possible > you have an .eslintrc file further up in your directory structure that is > interfering with the default (for instance in ~/.eslintrc). >
Hi, thanks for your reply (and this tool, of course). It indeed seems like it was my ~/.eslintrc that was interfering. Isn't it a pity though, that a config file in the root can wreck the build of eslint itself, esp. after the other steps taken to go dev-mode (uninstall -g, npm link)? I think it would make sense to just use the project's own ruleset for the development process, so that there is a correspondence with what happens in a travis run. /p > For future reference, you can check the last build of ESLint using Travis > CI: > https://travis-ci.org/eslint/eslint > > -N > > > On Fri, Jul 4, 2014 at 10:05 AM, Petter Envall <[email protected] > <javascript:>> wrote: > >> Hello, >> >> just checked out master and ran *npm test*, but to make it succeed I had >> to be more forgiving in the .eslintrc file. What's up with that? I have >> a proposal/pr cooking, but I'd rather not have to commit relaxing stuff to >> the config just like that. >> >> These are the problems reported in Makefile.js: >> >> ./Makefile.js >> 7:0 error Use the function form of "use >> strict" no-global-strict >> 280:37 warning Gratuitous parentheses around >> expression no-extra-parens >> 311:12 error Unexpected console >> statement no-console >> 317:16 error Unexpected console >> statement no-console >> 323:16 error Unexpected console >> statement no-console >> 330:12 error Unexpected console >> statement no-console >> 336:12 error Unexpected console >> statement no-console >> 342:12 error Unexpected console >> statement no-console >> 358:24 error Unexpected console >> statement no-console >> 365:24 error Unexpected console >> statement no-console >> 371:20 error Unexpected console >> statement no-console >> 380:12 error Unexpected console >> statement no-console >> 392:0 warning This function has too many parameters (5). Maximum >> allowed is 3 max-params >> 396:22 warning Gratuitous parentheses around >> expression no-extra-parens >> >> ✖ 14 problems >> >> >> And here's what I locally added to .eslintrc to carry on: >> , >> "no-console": 1, >> "max-params": [2, 6], >> "no-extra-parens": 1, >> "no-global-strict": 1 >> >> >> Regards >> >> /p >> >> -- >> You received this message because you are subscribed to the Google Groups >> "ESLint" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> For more options, visit https://groups.google.com/d/optout. >> > > > > -- > > ______________________________ > Nicholas C. Zakas > @slicknet > > Author, Professional JavaScript for Web Developers > Buy it at Amazon.com: > http://www.amazon.com/Professional-JavaScript-Developers-Nicholas-Zakas/dp/1118026691/ref=sr_1_3 > > -- You received this message because you are subscribed to the Google Groups "ESLint" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
