On Thu, Jan 09, 2003 at 11:58:46AM -0800, Guy Harris wrote: > On Thu, Jan 09, 2003 at 01:47:16PM -0600, Albert Chin wrote: > > There is inconsistent usage of plugindir in 0.9.8. In most instances, > > Makefile.in has: > > plugindir = @plugindir@ > > and in others (plugins/docsis/Makefile.am): > > plugindir = @PLUGIN_DIR@ > > > > I presume the correct usage is the latter? > > Given that "plugins/docsis/Makefile.am" is the only Makefile.am file > that uses "PLUGIN_DIR", there's no particular reason to presume that > it's the correct usage - and given that configure.in > > 1) defines PLUGIN_DIR as "$plugindir" > > and > > 2) does AC_SUBST on both of them > > the two of them should probably function the same, so "correct" is > probably merely an issue of aesthetics, not of correct operation. > > Most directory-name variables, at both the Makefile and autoconf level, > have all-lower-case names, so, from an aesthetic point of view, I'd > probably consider "plugindir" rather than "PLUGIN_DIR" correct.
--with-plugins is honored *only* by plugins/docsis/Makefile.am. PLUGIN_DIR="$plugindir" is set only as a default. I have no problem doing away with PLUGIN_DIR and having --with-plugins set $plugindir. At the moment, --with-plugins sets *onlyY $PLUGIN_DIR. -- albert chin ([EMAIL PROTECTED])
