Hi Niels,

Le 21 mai 09 à 14:00, Niels Grewe a écrit :

> Last night, I finally got around to tweak MediaKit's GNUmakefile so  
> that
> it handles the location of libav(codec|format)-headers more nicely.
> The attached patch does this by a combination of a shell conditional  
> and
> a sed one-liner. So it's probably not particularly robust and I
> desparately need feedback on whether this breaks with other setups  
> (mine
> is debian unstable with headers in /usr/include/ffmpeg/libav*).
> I'd be especially interested to hear whether a) this works with  
> systems
> which put the headers in /usr/include/libav* (meaning that pkg-config
> will not report any additional include-dirs) and b) versions with  
> ffmpeg
> which use the old-style header locations.

I just tested this patch on Ubuntu 9.04. With a little adjustment it  
works:
NEW_AVFORMAT_INCLUDE_DIR=`if [ -n $$(pkg-config --cflags-only-I  
libavformat) ]; then\
                                                                        ^ 
^^
-n option must be removed here exactly as in the previous libavcodec  
test, since pkg-config returns a new line and not a zero string when  
the include path is /usr/include.

However I'm not sure to understand why the patch is needed, does the  
current version refuses to build on your Debian system because the  
explicit include
'ADDITIONAL_OBJCFLAGS += -I/usr/include/libavcodec -I/usr/include/ 
libavformat' prevents the header to be corrrectly searched in /usr/ 
include/ffmepg/libav*?
This GNUmakefile as it is was working for me on older Ubuntu systems  
using the same include path as yours.

> Additionally, I seem to have found a way to get rid of the  
> (suppressed)
> deprecation warnings from libavcodec. You basically have to switch to
> avcodec_decode_audio3() for libavcodec-versions >= 52 in just one  
> place.
> Again, this is not tested against versions prior to 52 (svn snapshot
> from 2009-05-09), so I need input on this as well.

Looks far better than the current hack :-) I still need to test this  
patch and the previous one on an old Ubuntu system though.
I think the comment with the Ubuntu bug reference should be moved to  
MKMediaFile.m too since this problem is Ubuntu specific. Do you have  
the same issue on Debian too?

Cheers,
Quentin.


_______________________________________________
Etoile-dev mailing list
Etoile-dev@gna.org
https://mail.gna.org/listinfo/etoile-dev

Reply via email to