On Sat, May 23, 2009 at 04:07:55PM +0200, Quentin Mathé wrote:
> Is your Debian version using a recent FFMpeg version and putting the  
> headers in something like /usr/include/ffmpeg/libavcodec/libavcodec.h  
> rather than /usr/include/libavcodec/libavcodec.h ?  

That's exactly what's going on. Thank you for pointing it out! I didn't
even realize that I was being unclear about that. All other confusions
probably arise from this fact. Sorry for that.

> We should keep the check for avcodec_decode_audio2, it's a welcome  
> improvement. We should just match avcodec.h which declares it like that:
> #if LIBAVCODEC_VERSION_MAJOR < 53 <--- and not as it is currently in  
> the patch LIBAVCODEC_VERSION_INT  < ((52<<16)+(25<<8)+0)
> attribute_deprecated int avcodec_decode_audio2(AVCodecContext *avctx,  
> int16_t *samples, int *frame_size_ptr, const uint8_t *buf, int  
> buf_size);
> #endif

The avcodec_decode_audio2() deprecation occured at r18351 in the ffmpeg
svn, which corresponds to v52.25.0. That was the rationale for using
that version in the check (to get rid of the deprecation warning). 
But if we need to silence the deprecation warnings anyway, checking for
v53 is just fine since that's when the _audio2()-variant will go away.

Cheers, 


Niels

_______________________________________________
Etoile-dev mailing list
Etoile-dev@gna.org
https://mail.gna.org/listinfo/etoile-dev

Reply via email to