Le jeudi 25 mars 2010, à 15:45 -0600, Federico Mena Quintero a écrit :
> On Wed, 2010-03-24 at 09:55 +0100, Frederic Crozat wrote:
> > Le 23/03/2010 19:22, Federico Mena Quintero a écrit :
> > > On Tue, 2010-03-23 at 13:52 +0100, Vincent Untz wrote:
> > >
> > >> I'm a bit worried that people using a big font might get a sidebar
> > >> bigger than the main content of the window with this code (and a small
> > >> screen). Would it make sense to also use a min(result, screen_width / 4)
> > >> or something similar?
> > >
> > > Sure, I can trivially add that.
> > 
> > I'm with Vincent about this.
> 
> Fixed and pushed to gnome-2-30.  Thanks!

I guess this commit is the cause of:

libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -DG_DISABLE_DEPRECATED 
-DPANGO_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED 
-DGDK_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DG_DISABLE_SINGLE_INCLUDES 
-DGTK_DISABLE_SINGLE_INCLUDES -Wall -Wextra -Wno-missing-field-initializers 
-Wno-sign-compare -Wno-unused-parameter -Wdeclaration-after-statement 
-Werror-implicit-function-declaration -Wformat-security -Winit-self 
-Wmissing-declarations -Wmissing-include-dirs -Wmissing-noreturn 
-Wnested-externs -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings 
-fno-strict-aliasing -I../.. -I../../mail -I../../widgets -pthread -DORBIT2=1 
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gtk-2.0 
-I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo 
-I/usr/include/pango-1.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 
-I/usr/include/libpng12 -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 
-I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include 
-I/usr/include/libgnomecanvas-2.0 -I/usr/include/gail-1.0 
-I/usr/include/libart-2.0 -I/usr/include/libxml2 
-I/usr/include/gnome-desktop-2.0 -I/usr/include/startup-notification-1.0 
-I/usr/include/unique-1.0 -DORBIT2=1 -pthread 
-I/usr/include/evolution-data-server-2.30 -I/usr/include/glib-2.0 
-I/usr/lib/glib-2.0/include -I/usr/include/nss3 
-I/usr/include/nss-shared-helper -I/usr/include/nspr4 -I/usr/include/libxml2 
-I/usr/include/gconf/2 -I/usr/include/libsoup-2.4 -I/usr/include/orbit-2.0 
-I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include 
-I/usr/include/libgtkhtml-3.14 -I/usr/include/gtk-2.0 -I/usr/include/enchant 
-I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo 
-I/usr/include/pango-1.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 
-I/usr/include/libpng12 -I/usr/include/libgtkhtml-3.14/editor -DORBIT2=1 
-pthread -I/usr/include/evolution-data-server-2.30 -I/usr/include/glib-2.0 
-I/usr/lib/glib-2.0/include -I/usr/include/nss3 
-I/usr/include/nss-shared-helper -I/usr/include/nspr4 -I/usr/include/libxml2 
-I/usr/include/gconf/2 -I/usr/include/libsoup-2.4 -I/usr/include/orbit-2.0 
-I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include 
-DEVOLUTION_ETSPECDIR=\"/usr/share/evolution/2.30/etspec\" 
-DEVOLUTION_UIDIR=\"/usr/share/evolution/2.30/ui\" 
-DEVOLUTION_PRIVDATADIR=\"/usr/share/evolution/2.30\" 
-DG_LOG_DOMAIN=\"evolution-module-mail\" -fomit-frame-pointer 
-fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector 
-funwind-tables -fasynchronous-unwind-tables -MT 
libevolution_module_mail_la-e-mail-shell-view-private.lo -MD -MP -MF 
.deps/libevolution_module_mail_la-e-mail-shell-view-private.Tpo -c 
e-mail-shell-view-private.c  -fPIC -DPIC -o 
.libs/libevolution_module_mail_la-e-mail-shell-view-private.o
e-mail-shell-sidebar.c: In function 'guess_screen_width':
e-mail-shell-sidebar.c:199:3: error: implicit declaration of function 
'GTK_WIDGET_REALIZED'
e-mail-shell-sidebar.c:199:3: warning: nested extern declaration of 
'GTK_WIDGET_REALIZED'
make[3]: *** [libevolution_module_mail_la-e-mail-shell-sidebar.lo] Error 1

Can we get a 2.30.0.1 tarball that uses some non-deprecated API or, even
better, that doesn't use -DGTK_DISABLE_DEPRECATED by default?

Thanks,

Vincent

-- 
Les gens heureux ne sont pas pressés.
_______________________________________________
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers

Reply via email to