Hello!

  Nice investigation!

30.03.2019, 12:26, "KUSUMOTO Norio" <kusum...@na.rim.or.jp>:
> It seems to me key-down and key-up events are not desirable, not only in 
> Windows Factor.
> For example, on Mac Factor, when the "Q" key is pressed with a shift key, 
> gesture-logger
> reports:
>
>   T{ key-down { sym "Q" } }
>   User input: Q
>   T{ key-up { sym "Q" } }
>
> I think it should be:
>
>   T{ key-down { mods { S+ } } { sym "q" } }
>   User input: Q
>   T{ key-up { mods { S+ } } { sym "q" } }

  I think you are right, and this would solve a long-standing issue 
https://github.com/factor/factor/issues/1565
  I guess nobody had the time to dig into this, so your effort is much 
appreciated!

> I changed key-codes which is in 
> /Applications/factor/basis/ui/backend/cocoa/views/views.factor
> like this:
>
> CONSTANT: key-codes
> H{
>         { 29 "0" } ! <- added
>         { 18 "1" } ! <- added
>         { 19 "2" } ! <- added
>
>         { 0 "a" } ! <- added
>         { 11 "b" } ! <- added
>         { 9 "c" } ! <- added
>
>         { 71 "CLEAR" }
>         { 36 "RET" }
>         { 76 "ENTER" }
>         { 53 "ESC" }
>         { 48 "TAB" }
>         { 51 "BACKSPACE" }
>         { 115 "HOME" }
>         { 117 "DELETE" }
>         { 119 "END" }
>         { 122 "F1" }
>         { 120 "F2" }
>         { 99 "F3" }
>         { 118 "F4" }
>         { 96 "F5" }
>         { 97 "F6" }
>         { 98 "F7" }
>         { 100 "F8" }
>         { 123 "LEFT" }
>         { 124 "RIGHT" }
>         { 125 "DOWN" }
>         { 126 "UP" }
>         { 116 "PAGE_UP" }
>         { 121 "PAGE_DOWN" }
>     }
>
> Then events about "0", "1", "2", "a", "b" and "c" key are desirable for me.
>
> In conclusion, I think all keys which can exist should be added in key-codes.

  I'll try to see if I can fix the same for the Windows platform.

---=====--- 
 Александр



_______________________________________________
Factor-talk mailing list
Factor-talk@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/factor-talk

Reply via email to