On Wed, Aug 02, 2006 at 12:33:29AM -0600, Eric W. Biederman wrote:
> @@ -363,26 +364,23 @@ #ifdef DEBUG
> sym.st_size);
>
> #endif
> - if (sym.st_shndx == STN_UNDEF) {
> - /*
> - * NOTE: ppc64 elf .ro shows up a UNDEF section.
> - * From Elf 1.2 Spec:
> - * Relocation Entries: If the index is STN_UNDEF,
> - * the undefined symbol index, the relocation uses 0
> - * as the "symbol value".
> - * So, is this really an error condition to flag die?
> - */
> - /*
> + /* Don't allow weak symbols */
> + type = ELF32_ST_TYPE(sym.st_info)
> + if ((sym.st_shndx == STN_UNDEF) && (
We are comparing section index so to be technically correct should not
it be.
sym.st_shndx == SHN_UNDEF.
> + (type == STT_NOTYPE) || (type == STT_OBJECT) ||
> + (type == STT_FUNC) ||(type == STT_TLS)))
> + {
> die("Undefined symbol: %s\n",
> strtab + sym.st_name);
> - */
> - continue;
> }
> sec_base = 0;
> if (sym.st_shndx == SHN_COMMON) {
> die("symbol: '%s' in common section\n",
> strtab + sym.st_name);
> }
> + else if (sym.st_shndx == STN_UNDEF) {
> + sec_base = 0;
> + }
Same here.
> else if (sym.st_shndx == SHN_ABS) {
> sec_base = 0;
>
Thanks
Vivek }
_______________________________________________
fastboot mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/fastboot
