Mohan Kumar M <[EMAIL PROTECTED]> writes: > On Wed, Aug 02, 2006 at 12:33:29AM -0600, Eric W. Biederman wrote: >> > I assume the "undefined" entry is the R_PPC64_TOC reloc above. When >> > this relocation type has no symbol, it should resolve to the TOC pointer >> > used in that object file. >> >> That sounds reasonable. I have no problem with keeping things if we can >> actually process them. >> >> I do have an issue with weak symbols and want to make that an error >> in this context. Because if we have them it is a programmer error, >> and an all to easy mistake to make. >> >> So it looks like I can make my sanity check for weak symbols a little >> more specific and the Mohan can make certain we handle this case. >> >> Mohan if I understand what is happening correctly this sufficiently >> relaxes the check for weak symbols so you can process this relocation. >> >> Can you try this and see if you can make this case work? >> > Hi Eric, > > All .rela.opd entries with R_PPC64_TOC relocation type has r_info as zero and > elf_sym() retrives elf_sym as STN_UNDEF symbol only. > > So can we check for the section name ".rela.opd" instead of getting the symbol > and checking for weak symbols? > > Any other thoughts?
I would like to avoid that. We seem to be able to get the symbol correctly. I believe we can check the type of the symbol. But regardless of checking the type of the symbol if you comment out my sanity check (and not put a continue in there). Can you properly process this relocation type? For the symbol that is in section SHN_UNDEF. What is it's sym.st_info? I think it looked like 0x33 on your dump with readelf. But I'm not really certain. Currently I don't see anything that makes it look like we need to check for a section name, and I prefer it like that. The basic principle is that you should be able to handle this relocation. Once we can properly handle this type of relocation we can look very closely at my relocation tag and see what is possible. Eric _______________________________________________ fastboot mailing list [email protected] https://lists.osdl.org/mailman/listinfo/fastboot
