On Tue, 19 Sep 2006 21:01:53 +0530, Mohan Kumar M wrote: > On Tue, Sep 19, 2006 at 12:03:33PM +0530, Mohan Kumar M wrote: >> >> When the boot loader/kernel is not configured to reserve memory for >> crashkernel and the user tries to load the kdump kernel using kexec -p, >> tools does not give a meaningful error message. >> >> The following patch checks for the "crashkernel=" parameter in the >> /proc/cmdline and if "crashkernel=" is present then only calls the >> corresponding kexec system call to load the kdump kernel image. >> Otherwise it gives the error message and exits. >> >> Any comment, suggestion? >> > > There are some issues in this patch. > > I shall repost the patch tomorrow. > > Sorry for the inconvenience.
Hi, I am wondering if parsing /proc/cmdline is really the best way to go here. Wouldn't it be easier to get a hold of the string that is passed to --append directly? Other than that, the patch looks fine, though could you be sure to make it < 80 columns per line. Thanks -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ _______________________________________________ fastboot mailing list [email protected] https://lists.osdl.org/mailman/listinfo/fastboot
