On Fri, Sep 22, 2006 at 09:54:59AM -0400, Vivek Goyal wrote: > On Fri, Sep 22, 2006 at 02:37:35PM +0900, Horms wrote: > > On Fri, Sep 22, 2006 at 10:10:32AM +0530, Mohan Kumar M wrote: > > > Haren Myneni wrote: > > > > > > > > We are already looking for crashkernel segment before loading the kdump > > > > image - crashdump-<arch>.c. Ex: for ppc64, reading > > > > linux,crashkernel-size property and for i386/x86_64, from /proc/iomem. > > > > > > > > Why do not we display the error message and exit from here? > > > > > > > The issue is when memory for crashkernel is not reserved, the error > > > message is not displayed properly. > > > > > > For eg, in PPC64, the error message will be: > > > /proc/device-tree/chosen/linux,crashkernel-base: No such file or directory > > > get memory ranges:0 > > > Warning: append= option is not passed. Using the first kernel root > > > partition > > > /proc/device-tree/chosen/linux,crashkernel-base: No such file or directory > > > Could not find a free area of memory of 74ac00 bytes... > > > Base address: ffffffff is not page aligned > > > > > > i386 kexec tool also does not clearly report the error. > > > > > > The tool has to inform the user about what exactly happened and what > > > should be done in order to successfully load the kdump kernel. > > > > Its a fairly generic problem. It would be nice > > to have a fairly generic solution. > > > > I was not that excited about the original patch which reads from /proc > > to find the command line. The programme already has the command line, > > and at least in the invocations I am familiar with examining > > what --append has been set to should be sufficient. > > Hi Horms, > > --append will only have command line for the kernel which is yet to be > booted and in this case one would like to know if currently running > kernel has been booted with crashkernel= option or not. Am I missing > something?
Of course, you are right. I was confused. In that case I guess peeking in /proc/cmdline is a good way to go. -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ _______________________________________________ fastboot mailing list [email protected] https://lists.osdl.org/mailman/listinfo/fastboot
