Bob Montgomery wrote:
>
> In kexec-tools-testing: kexec/arch/ia64/kexec-elf-ia64.c:
>
> The "=" in "(mem_max = ULONG_MAX)" looks suspicious. Intended?
>
> if (info->kexec_flags & KEXEC_ON_CRASH ) {
> if ((mem_min == 0x00) && (mem_max = ULONG_MAX)) {
> fprintf(stderr, "Failed to find crash kernel region
> in /proc/iomem\n");
>
> No actual bug, just noticed while looking for something else.
>
> Bob Montgomery
If mem_min can legally be set to zero, then it certainly
would override the --mem-max option, or whatever got set
there in get_memory_ranges().
Not to mention that the spelling of the --mem-min and
--mem-max usage strings could use fixing:
printf(
"Usage: kexec [OPTION]... [kernel]\n"
"Directly reboot into a new kernel\n"
"\n"
" -h, --help Print this help.\n"
" -v, --version Print the version of kexec.\n"
" -f, --force Force an immediate kexec, don't call
shutdown.\n"
" -x, --no-ifdown Don't bring down network interfaces.\n"
" (if used, must be last option
specified)\n"
" -l, --load Load the new kernel into the current
kernel.\n"
" -p, --load-panic Load the new kernel for use on panic.\n"
" -u, --unload Unload the current kexec target
kernel.\n"
" -e, --exec Execute a currently loaded kernel.\n"
" -t, --type=TYPE Specify the new kernel is of this
type.\n"
" --mem-min=<addr> Specify the lowest memory addres to load
code into.\n"
" --mem-max=<addr> Specify the highest memory addres to
load code into.\n"
"\n"
"Supported kernel file types and options: \n"
);
_______________________________________________
fastboot mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/fastboot
