On Tue, Dec 05, 2006 at 02:18:48PM -0500, Dave Anderson wrote:
> Bob Montgomery wrote:
> 
> >
> > In kexec-tools-testing: kexec/arch/ia64/kexec-elf-ia64.c:
> >
> > The "=" in "(mem_max = ULONG_MAX)" looks suspicious.  Intended?
> >
> >         if (info->kexec_flags & KEXEC_ON_CRASH ) {
> >                 if ((mem_min == 0x00) && (mem_max = ULONG_MAX)) {
> >                         fprintf(stderr, "Failed to find crash kernel region 
> > in /proc/iomem\n");
> >
> > No actual bug, just noticed while looking for something else.
> >
> > Bob Montgomery
> 
> If mem_min can legally be set to zero, then it certainly
> would override the --mem-max option, or whatever got set
> there in get_memory_ranges().

I think it is an error.

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/

_______________________________________________
fastboot mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/fastboot

Reply via email to