On Thu, Dec 21, 2006 at 10:49:39AM +0530, Sachin P. Sant wrote: > Horms wrote: > >Use the appropriate format in debug print statements. > > > >Cc: Sachin P. Sant <[EMAIL PROTECTED]> > >Signed-off-by: Simon Horman <[EMAIL PROTECTED]> > > > >Index: kexec-tools-unstable/kexec/arch/ppc64/kexec-elf-ppc64.c > >=================================================================== > >--- kexec-tools-unstable.orig/kexec/arch/ppc64/kexec-elf-ppc64.c > >2006-12-20 15:05:18.000000000 +0900 > >+++ kexec-tools-unstable/kexec/arch/ppc64/kexec-elf-ppc64.c 2006-12-20 > >15:06:10.000000000 +0900 > > > Thanks Horms for this patch. While we are at it, here is another > patch to fix the problem of printing wrong debug information in > kexec-ppc64.c file. > > Thanks > -Sachin > > Signed-Off-by : Sachin Sant <[EMAIL PROTECTED]> >
> * In kexec-ppc64.c, wrong array name was used to print DEBUG information. > * Use the correct array name while printing debug information. > > Signed-off-by : Sachin Sant <[EMAIL PROTECTED]> > --- > > diff -Naurp a/kexec/arch/ppc64/kexec-ppc64.c b/kexec/arch/ppc64/kexec-ppc64.c > --- a/kexec/arch/ppc64/kexec-ppc64.c 2006-12-21 10:29:32.000000000 +0530 > +++ b/kexec/arch/ppc64/kexec-ppc64.c 2006-12-21 10:42:34.000000000 +0530 > @@ -176,7 +176,10 @@ static int get_base_ranges() > base_memory_range[local_memory_ranges].type = RANGE_RAM; > local_memory_ranges++; > #ifdef DEBUG > - fprintf(stderr, "%016Lx-%016Lx : %x\n", > memory_range[local_memory_ranges-1].start, > memory_range[local_memory_ranges-1].end, > memory_range[local_memory_ranges].type); > + fprintf(stderr, "%016Lx-%016Lx : %x\n", > + base_memory_range[local_memory_ranges-1].start, > + base_memory_range[local_memory_ranges-1].end, > + base_memory_range[local_memory_ranges-1].type); > #endif > fclose(file); You can alternatively use dfprintf() to print debug messages. Will save you the overhead of putting #ifdef DEBUG conditionals. Thanks Vivek _______________________________________________ fastboot mailing list [email protected] https://lists.osdl.org/mailman/listinfo/fastboot
