On Thu, Dec 21, 2006 at 03:17:31PM +0900, Horms wrote: > On Thu, Dec 21, 2006 at 11:01:57AM +0530, Vivek Goyal wrote: > > [snip] > > > You can alternatively use dfprintf() to print debug messages. Will save > > you the overhead of putting #ifdef DEBUG conditionals. > > Indeed. How about this? >
Looks good. Thanks Vivek > -- > Horms > H: http://www.vergenet.net/~horms/ > W: http://www.valinux.co.jp/en/ > > * In kexec-ppc64.c, wrong array name was used to print DEBUG information. > * Use the correct array name while printing debug information. > > Signed-off-by : Sachin Sant <[EMAIL PROTECTED]> > > * Make use of dfprintf > * Use %llx instead of %L for long long arguments > > Signed-off-by: Simon Horman <[EMAIL PROTECTED]> > > Index: kexec-tools-unstable/kexec/arch/ppc64/kexec-ppc64.c > =================================================================== > --- kexec-tools-unstable.orig/kexec/arch/ppc64/kexec-ppc64.c 2006-12-21 > 15:09:31.000000000 +0900 > +++ kexec-tools-unstable/kexec/arch/ppc64/kexec-ppc64.c 2006-12-21 > 15:12:02.000000000 +0900 > @@ -175,9 +175,10 @@ > ((unsigned long long *)buf)[1]; > base_memory_range[local_memory_ranges].type = RANGE_RAM; > local_memory_ranges++; > -#ifdef DEBUG > - fprintf(stderr, "%016Lx-%016Lx : %x\n", > memory_range[local_memory_ranges-1].start, > memory_range[local_memory_ranges-1].end, > memory_range[local_memory_ranges].type); > -#endif > + dfprintf(stderr, "%016llx-%016llx : %x\n", > + base_memory_range[local_memory_ranges-1].start, > + base_memory_range[local_memory_ranges-1].end, > + base_memory_range[local_memory_ranges-1].type); > fclose(file); > } > closedir(dmem); > _______________________________________________ fastboot mailing list [email protected] https://lists.osdl.org/mailman/listinfo/fastboot
