#35: Use floating panels for dialogs
--------------------------+-------------------------------------------------
Reporter: FredCK | Owner: martinkou
Type: New Feature | Status: assigned
Priority: Normal | Milestone: FCKeditor 2.6
Component: General | Version:
Resolution: | Keywords: Review-
--------------------------+-------------------------------------------------
Changes (by fredck):
* keywords: Review? => Review-
Comment:
Those are some of my findings so far:
* The color selector dialog is not working.
* RefreshContainerSize is duplicated in fckdialog.html.
* Use FCKTools.RegisterDollarFunction instead of "function $".
* Comments should respect our coding style
* The throbber should be a DOM effect solution, with no images to be
downloaded.
* Review FCKTools.Hitch. It seems it is not needed.
* Review the Main object. It seems it is useless. We can group some
functions in a private scope using (function(){})(), defining public
functions with window.PublicFunction. All other function, which don't need
a private scope, can be defined in the window scope directly.
* The "API export" block can be removed. Only the Size and Tabs entries
need to be exported to the window scope, so we can do it manually. E.g.
window.AddTab = Tabs.AddTab. We will probably have less and clearer code
in this way.
* The branch should be aligned with trunk, to properly review it.
--
Ticket URL: <http://dev.fckeditor.net/ticket/35#comment:51>
FCKeditor <http://www.fckeditor.net>
The text editor for Internet
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
