#35: Use floating panels for dialogs
--------------------------+-------------------------------------------------
Reporter: FredCK | Owner: martinkou
Type: New Feature | Status: assigned
Priority: Normal | Milestone: FCKeditor 2.6
Component: General | Version:
Resolution: | Keywords: Review-
--------------------------+-------------------------------------------------
Comment (by fredck):
Ok, I've completed the review. I'm happy to say that we are almost there!
* Please check my last commits: [1366], [1367], [1369]! and [1370].
test1.html:
* In the third dialog open, a JS error has been thrown. Reproducible with
IE7 and IE6, but it's not constant. Ignoring it, the test continues
without problems.
* Sad to say that, but there is a constant memory leak in IE6 and IE7.
I've checked it before applying any change to the code during the review.
dialog.html:
* Check if Editor() is really needed because it's... weird! E variable
would make things clearer, and I doubt about its memory leak consequences
as it should point to a pure JavaScript object.
Closing these things, added to the things in my previous comments would
make it probably ready, finally. I'm anxious to see it moved to trunk!
--
Ticket URL: <http://dev.fckeditor.net/ticket/35#comment:56>
FCKeditor <http://www.fckeditor.net>
The text editor for Internet
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
