#1865: Contextmenu in last row of a table with thead doesn't work
-------------------------------+--------------------------------------------
 Reporter:  kwillems           |       Owner:  alfonsoml      
     Type:  Bug                |      Status:  assigned       
 Priority:  Normal             |   Milestone:  FCKeditor 2.6.4
Component:  UI : Context Menu  |     Version:  FCKeditor 2.5.1
 Keywords:  Confirmed          |  
-------------------------------+--------------------------------------------

Comment(by alfonsoml):

 The change in _CreateTableMap will make the DragResizeTable plugin fail.
 [[BR]]
 The getElementsByTagNames gets all the contents of a node, including sub-
 tables, so that will generate errors.[[BR]]
 Unless strictly necessary it's better to focus just on one bug, trying to
 fix several bugs at once makes a more complex patch that it's harder to
 review

 As the pattern
 {{{
         FCKTableHandler.saveThead( refCell );
         this._InstallTableMap( tableMap, refCell.parentNode.parentNode ) ;
         FCKTableHandler.restoreThead ( FCKTools.GetElementAscensor(
 refCell, 'TABLE' ) ) ;
 }}}
 is used several times It might be more logical to put that as a function.

-- 
Ticket URL: <http://dev.fckeditor.net/ticket/1865#comment:18>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac

Reply via email to