#1865: Contextmenu in last row of a table with thead doesn't work
-------------------------------+--------------------------------------------
Reporter: kwillems | Owner: alfonsoml
Type: Bug | Status: assigned
Priority: Normal | Milestone: FCKeditor 2.6.4
Component: UI : Context Menu | Version: FCKeditor 2.5.1
Keywords: Confirmed |
-------------------------------+--------------------------------------------
Comment(by alfonsoml):
Whenever you attach a new patch, don't overwrite the previous one, because
it will be harder to understand the comments without the original code.
If you want to keep that getElementsByTagNames function then it should be
placed in the proper module, and justify why you need it (with the risk
involved that will need later adjustments) instead of getting just the
cells with a simple loop. And also is it really needed to sort the output?
The fact that you don't like nested tables doesn't matter. The rest of the
world uses them so the code must take them into account.
Creating a new function/adjusting the _InstallTableMap function is a must.
All the calls to _InstallTableMap now are wrapped with these new
functions, so there's no reason to keep them separate. Also, nowhere else
the SaveThead and RestoreThead are used so that's another reason to "hide"
them in a single call.
--
Ticket URL: <http://dev.fckeditor.net/ticket/1865#comment:21>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
