#2862: plugin:maximize porting from v2
-------------------------------+--------------------------------------------
Reporter: garry.yao | Owner: garry.yao
Type: New Feature | Status: assigned
Priority: High | Milestone: CKEditor 3.0
Component: General | Version:
Keywords: Confirmed Review? |
-------------------------------+--------------------------------------------
Changes (by garry.yao):
* keywords: Confirmed Review- => Confirmed Review?
Comment:
* Update the patch according to Fred's review points, except for:
[[BR]]
> * I've noted that you are proposing a completely new thing here. The V2
code is already well tested and works well. I've also check the size of
each implementation and V2 gives me 2.4KB while the patch gives 3.9KB. The
extra 1.5KB brings me many doubts on the real benefit of the new approach.
>
Thanks for reminding me on the footprint measurement, yes it add extra
bytes all due to the nasty bug of iframe content lose, hopefully browsers
could fix this bug later so the patch would be reduced a lot, while the
valuable things bring by this approach would be it utilize a 'semantic
correct' way to turn a element into fullscreen, without imposing changes
to all other elements below document & body , it could avoid former bugs
like #1211 and #2474.
>
> * The setMode function should not suffer changes. You are using that to
reload the contents. The "loadSnapshot" feature is being proposed at the
latest patch in #2763, and that should be the way to go instead.
>
I try to accomplish this with the proposed '''loadSnapshot''', but result
in founding the head part of the document unable to reload which contains
document css definition, so temporarily I would be reluctance to change
'''editor.setMode'''.
* Currently tested on two modes of all supportable browsers.
* The patch also proposing the following fix after discussing with
Martin: [[BR]]
Add a '''forceSelectionCheck''' function to
''_source/plugins/selection/plugin.js''which helps on manually check
selection change.
--
Ticket URL: <http://dev.fckeditor.net/ticket/2862#comment:10>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
