#2862: plugin:maximize porting from v2
-------------------------------+--------------------------------------------
Reporter: garry.yao | Owner: garry.yao
Type: New Feature | Status: assigned
Priority: Normal | Milestone: CKEditor 3.0
Component: General | Version:
Keywords: Confirmed Review- |
-------------------------------+--------------------------------------------
Changes (by martinkou):
* keywords: Confirmed Review? => Confirmed Review-
Comment:
The patch works well. I've tested it with IE, Opera, Safari, Firefox;
under Standards mode and Quirks mode; and with static positioning and
absolute positioning. It worked for all cases. But there're still some
minor style problems to be fixed in the code:
1. Please follow the conventions we already have and use this._.restore
instead of this._restore for private variable.
(_source/plugins/maximize/plugin.js, line 25).
2. Please don't add a space between "function" and "(".
(_source/plugins/maximize/plugin.js, lines 48, 62, 84, 96, 112, 131, 158,
168, 180, 207, 220) - a regular expression substitution should fix that
easily.
3. Missing spaces in brackets. (Lines 19, 158, 338).
4. I'm not really sure, but is the hack in Lines 344-347 still needed
after your fix in #2927?
5. The toolbar's button arrangement is now changed, please place your
maximize button just before the show blocks button in your new patch.
--
Ticket URL: <http://dev.fckeditor.net/ticket/2862#comment:15>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
