#2885: Implement the div container command.
-------------------------------+--------------------------------------------
Reporter: martinkou | Owner: garry.yao
Type: Task | Status: assigned
Priority: Normal | Milestone: CKEditor 3.0
Component: General | Version: SVN
Keywords: Confirmed Review- |
-------------------------------+--------------------------------------------
Changes (by martinkou):
* keywords: Confirmed Review? => Confirmed Review-
Comment:
Still a few bugs:
1. I think I've mentioned this to you on Skype already. The div container
command is supposedly used for laying out documents, so there's no limit
on the number of div containers you can nest. Thus, the create div command
should already create a new div to enclose all selected blocks, including
previously created div containers.
To let users edit existing div containers, there should be a separate
edit div command, which edits the div nearest to the selection range. The
edit div command is expected to be accessible via context menu. We don't
have a context menu yet, but that command still needs to be implemented
and tested (via a toolbar button for testing purpose).
2. Line 98 should be
{{{
ancestor = ancestor.getCommonAncestor( blockGroups[ i ][ j ], true );
}}}
Missing the true flag means that if multiple blocks are selected and
the create div command is executed, then you get a JavaScript error.
3. The problems mentioned in _source/lang.en.js are still not fixed.
4. Now that the toolbar button layout is changed, please place your
create div toolbar button after the blockquote button in your new patch.
Just like how it was in v2.
--
Ticket URL: <http://dev.fckeditor.net/ticket/2885#comment:6>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
