#2970: Refactor CKEDITOR.dom.documentFragment
-------------------------------+--------------------------------------------
Reporter: garry.yao | Owner: garry.yao
Type: Task | Status: assigned
Priority: Normal | Milestone: CKEditor 3.0
Component: General | Version: SVN
Keywords: Confirmed Review- |
-------------------------------+--------------------------------------------
Changes (by fredck):
* keywords: Confirmed Review? => Confirmed Review-
Comment:
At documentFragment:
* The "type" property should not be copied from element.prototype.
* As "insertAfterNode" has been simplified, the three "var" declarations
are not anymore needed.
At tools.extend:
* Let's make it possible to have both the "properties list" and
"overwrite" parameters together. It means that the function should accept
the following params:
* ( target, source[,souce(n)] )
* ( target, source[,souce(n)], {Boolean}overwrite )
* ( target, source[,souce(n)], {Boolean)overwrite,
{Object}propertiesList )
Note that "propertiesList" has been placed "after" overwrite because we
can also make a small performance improvement and use an object instead of
an array (indexOf) is not that good.
* As mentioned above, make the properties list be an object (hashtable).
It means the function call must pass the paramenter like { append:1,
getFirst:1, getLast:1 }, instead of [ 'append', 'getFirst', 'getLast' ].
* Please try to follow our code standards even on comments:
{{{
// Whether it has a properties list.
NOT
//whether it has a properties list
}}}
* Please do not add a comment in the middle of conditions, like you did
at line 131.
Also, I've always bee afraid about IE's compatibility with
documentFragment. So, please include also tests for all documentFragment
functions.
--
Ticket URL: <http://dev.fckeditor.net/ticket/2970#comment:4>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
