#2970: Refactor CKEDITOR.dom.documentFragment
-------------------------------+--------------------------------------------
Reporter: garry.yao | Owner: garry.yao
Type: Task | Status: assigned
Priority: Normal | Milestone: CKEditor 3.0
Component: General | Version: SVN
Keywords: Confirmed Review- |
-------------------------------+--------------------------------------------
Changes (by fredck):
* keywords: Confirmed Review? => Confirmed Review-
Comment:
I'm not able to apply this patch. I have an error at line 213.
Looking at the patch preview on Trac, I can find some issues though.
* Based on the added documentation, and having you used the "in" overator
over propertiesList, we correctly assume that propertiesList should be an
object. But, you are still making isArray checks there, and still passing
the properties list as an Array in documentFragment. Something is wrong
here.
* There is a simpler way to set overwrite and propertiesList.
* There are still coding style issues, specially with whitespaces.
* The square brackets are not to be removed from the documentation. They
indicate that the argument is optional.
* {{{( propertiesList && ( propertyName in propertiesList ) ||
!propertiesList )}}} !!! What about {{{( !propertiesList || ( propertyName
in propertiesList ) )}}}
--
Ticket URL: <http://dev.fckeditor.net/ticket/2970#comment:6>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
