#3152: basicstyle override tag not working
-------------------------------+--------------------------------------------
Reporter: garry.yao | Owner: garry.yao
Type: Bug | Status: assigned
Priority: Normal | Milestone: CKEditor 3.0
Component: General | Version: SVN (FCKeditor)
Keywords: Confirmed Review- |
-------------------------------+--------------------------------------------
Changes (by fredck):
* keywords: Confirmed Review? => Confirmed Review-
Comment:
After applying the patch, the basic style detection stoped working. It's
enough to load a sample and place the caret inside the bold words. The
bold button will not get highlighted.
Other than that:
- On "checkElementRemovable":
- The "element.getName()" check has been removed, but the code that
followed it must be executed just in the case of element name match. So,
that code must now go inside an "if" block, just like in V2.
- The function must "return false" at it's very last line.
- Actually, it's enough to precisely replicate the V2 code.
- We have changed the way utility functions are being defined in the
style plugin code. So, just like getAttributesForComparison, getOverrides
should be a private function, not anymore a propert into the style class.
- In removeFromElement, the added loop on "attributes" is a duplicate of
the code already present a few lines above in the same function.
- There are several unrelated (and wrong) coding style changes on the
"for" blocks.
--
Ticket URL: <http://dev.fckeditor.net/ticket/3152#comment:4>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
This SF.net email is sponsored by:
High Quality Requirements in a Collaborative Environment.
Download a free trial of Rational Requirements Composer Now!
http://p.sf.net/sfu/www-ibm-com
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
