#3152: basicstyle override tag not working
-------------------------------+--------------------------------------------
 Reporter:  garry.yao          |       Owner:  garry.yao      
     Type:  Bug                |      Status:  assigned       
 Priority:  Normal             |   Milestone:  CKEditor 3.0   
Component:  General            |     Version:  SVN (FCKeditor)
 Keywords:  Confirmed Review-  |  
-------------------------------+--------------------------------------------
Changes (by fredck):

  * keywords:  Confirmed Review? => Confirmed Review-


Comment:

 Still a new issues:

  * The cache trick at line 936 has no effect. It simply changes the
 pointer of arguments.callee to another function, but will not
 (fortunately) change future calls for getOverrides. I've said fortunately,
 because getOverrides is not a private function, used by several different
 styles. The right solution is caching it in the parameter "style" object.

  * If you look at the colobutton plugin, "colorButton_foreStyle" defines a
 style that has an override for the <font> element, containing the "color"
 attribute (null means "any value" there). It means that if you have the
 following:

 {{{
 <font color="red">Test</font>
 }}}

 Doing a "select all" and applying a new color, the <font> tag should
 disappear. What we have instead is the following:

 {{{
 <span style="color: rgb(0, 0, 255);"><font color="red">Test</font></span>
 }}}

  * As you will have a chance to review your changes, please fix the coding
 style at line 679.

-- 
Ticket URL: <http://dev.fckeditor.net/ticket/3152#comment:6>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
This SF.net email is sponsored by:
High Quality Requirements in a Collaborative Environment.
Download a free trial of Rational Requirements Composer Now!
http://p.sf.net/sfu/www-ibm-com
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac

Reply via email to