#3372: Undo /  Redo Text Selection Bug
-------------------------------+--------------------------------------------
 Reporter:  jheard             |       Owner:  tobiasz.cudnik 
     Type:  Bug                |      Status:  assigned       
 Priority:  Normal             |   Milestone:  CKEditor 3.0   
Component:  Core : Undo/Redo   |     Version:  FCKeditor 2.6.3
 Keywords:  Confirmed Review-  |  
-------------------------------+--------------------------------------------
Changes (by garry.yao):

  * keywords:  Confirmed Review? => Confirmed Review-


Comment:

 The patch works, two minor issues identified:
  1. Sorry for unclear explanation of the 'Arrow Keys', actually they
 shouldn't cause snapshot but they're responsible for reseting '''typing'''
 state, take the following TC as example:
   1. Delete all contents and begin to type some characters;
   1. Navigate into the middle of the existed text line with 'Arrow Left';
   1. Begin to type some characters from this new position;
   1. Perform 'undo'.
    * Expected Result: There should be two undo points saved;
    * Actual Result: There's only one snap.
  1. Plz comment out the following keymap OR refactor them into constants,
 make sure there's no magic number:
 {{{
 var modifierCodes = { 8:1, 46:1/*, 39:1, 40:1, 38:1, 37:1*/ };
 }}}

-- 
Ticket URL: <http://dev.fckeditor.net/ticket/3372#comment:13>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, & 
iPhoneDevCamp asthey present alongside digital heavyweights like Barbarian
Group, R/GA, & Big Spaceship. http://www.creativitycat.com 
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac

Reply via email to