#3372: Undo / Redo Text Selection Bug
-------------------------------+--------------------------------------------
Reporter: jheard | Owner: tobiasz.cudnik
Type: Bug | Status: assigned
Priority: Normal | Milestone: CKEditor 3.0
Component: Core : Undo/Redo | Version: FCKeditor 2.6.3
Keywords: Confirmed Review- |
-------------------------------+--------------------------------------------
Changes (by garry.yao):
* keywords: Confirmed Review? => Confirmed Review-
Comment:
Sorry for that I've just spotted another issue with the patch at L202:
{{{
isSelected = !this.editor.getSelection().getRanges()[0].collapsed // Check
selection for every keystroke.
}}}
This should be avoided as Fred said - native range retrieving without
properly cached is an heavy operation, and we're now treating this for
every keystroke, it will definitely has an impact on the overall PF.
[[BR]]
Based on this, I think we should find a replacing approach, e.g. reset the
state on every native selection change instead of manual checking here,
how do you think?
--
Ticket URL: <http://dev.fckeditor.net/ticket/3372#comment:21>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet
------------------------------------------------------------------------------
OpenSolaris 2009.06 is a cutting edge operating system for enterprises
looking to deploy the next generation of Solaris that includes the latest
innovations from Sun and the OpenSource community. Download a copy and
enjoy capabilities such as Networking, Storage and Virtualization.
Go to: http://p.sf.net/sfu/opensolaris-get
_______________________________________________
FCKeditor-Trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fckeditor-trac
