Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gnubg https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189713 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From [EMAIL PROTECTED] 2006-06-01 10:39 EST ------- No formal review, just the results of a quick scan, which has turned up enough for you to work on for now: Why call autogen.sh? thats concidered bad practice unless absolutly nescesarry, and if you must you should do so from %setup not %install Also BR: automake implies autoconf, so the BR: autoconf is extranous and should be removed. (Notice if you remove the autogen.sh call that you then should also remove the autoxxx and libtool BR's). Also BR:L glib2 is plain wrong this is a gtk1 app right, so it should be glib-devel, which is implied by BR: gtk+-devel, please remove the BR glib2. Don't call ./configure yourself instead use %configure (that will fix the rpmlint error) you can call it with your own args added like this: %configure --with-python \ --without-gdbm \ --without-guile \ --without-timecontrol \ --without-board3d "make prefix=$RPM_BUILD_ROOT%{_prefix} install-strip" is dead wrong, use: make install DESTDIR=$RPM_BUILD_ROOT Stripping is wrong, rpmbuild will do this for you, and if you DIY, the -debuginfo package will be useless. Unowned directories: %{_datadir}/gnubg %{_datadir}/gnubg/met %{_datadir}/gnubg/doc %{_datadir}/gnubg/scripts %{_datadir}/gnubg/sounds -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
