Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bouncycastle


           What    |Removed                     |Added
             Status|NEEDINFO_REPORTER           |ASSIGNED

------- Additional Comments From [EMAIL PROTECTED]  2006-07-10 17:31 EST -------
(In reply to comment #2)
> - Buildroot should be
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)


> - Remove Epoch: 0


> - Specifying 0 epoch on Requires and BuildRequires is not necessary.  Remove 
> them.


> - RPM_BUILD_ROOT=bctmp aot-compile-rpm <-- what is this doing?  Why reset the
> buildroot?

Yeah, I realized I don't need this, it's already done by aot-compile-rpm in the
%install section.

> - Post and postun scripts should probably have logic for final removal vs
> upgrade.  As it stands you'll run rebuild-security-providers and 
> rebuild-gcj-db
> twice every time you upgrade the package.  Once for the new package, and once
> for removing the old package.


> rpmlint output:
> E: bouncycastle zero-length
> W: bouncycastle-debuginfo objdump-failed objdump:
> File format not recognized
> W: bouncycastle mixed-use-of-spaces-and-tabs
> W: bouncycastle non-conffile-in-etc
> W: bouncycastle objdump-failed objdump:
> File format not recognized
> The Zero length file, I see it just being touched.  Does it just need to 
> exist?
>  If so, we can ignore the error.  However it should be marked as a config 
> file.

The filename 2000-org.bouncycastle.jce.provider.BouncyCastleProvider is
interpreted by rebuild-security-providers as <provider priority>-<provider
package name>, and is used to rebuild /usr/lib/security/  Its
contents are meaningless.  I don't want to mark it as %config because then if
someone edits it and then updates, a backup file with the extension .rpmsave
will be created and will cause a bogus entry to appear in

> Not sure about the objdump warnings.

I ran rpmlint (0.77-1.fc5) on my x86 workstation and didn't see those warnings.

I'll post the updated package shortly.

Configure bugmail:
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

Fedora-package-review mailing list

Reply via email to