Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kadu - Gadu-Gadu client for online messaging https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199192 ------- Additional Comments From [EMAIL PROTECTED] 2006-07-23 14:56 EST ------- > > Please install rpmlint on your system and use it on the packages while > > developing the specfile. > > I've already installed it, but most of your errors wasn't showed for me by > rpmlint, do you use any arguments to it? No, just use it on the src.rpm as well as on the binary rpm. Maybe you only used it on the src.rpm? > note that --enable-debug compiles in very noisy console output (binary is > ~8-10% bigger) Isn't this removed when stripping off the symbols? rpm does that automatically and generates debuginfo packages with these symbols. So usually one installs the stripped binary w/o the extra space and when an issue comes up one can install the matching debuginfo rpm and run gdb on it. I wrote: > - "unstripped-binary-or-object": Fix by making the modules executable either > with chmod at the end of %install of with %attr/%defattr That was wrong. I rebuilt the latest src.rpm and the unstripped binaries are still around. You need to chmod then, %attr alone doesn't help as it is taken into account *after* the debuginfo creation. Sorry for the misleading information. Can you fix that and also %exclude %{_kadudir}/AUTHORS %{_kadudir}/ChangeLog %{_kadudir}/COPYING %{_kadudir}/HISTORY %{_kadudir}/README %{_kadudir}/THANKS and instead add them with %doc? All other points were checked and are OK. For reference: + spec file name: OK + sources match upstream: OK + American English: OK + permissions: OK (on manifest level) - license (COPYING) included, but not in %doc: not OK - rpmlint output: $ rpmlint *rpm | grep -v kadu-.*no-documentation W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/voice.so W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/autoaway.so W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/config_wizard.so W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/migration.so W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/window_notify.so W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/dcc.so W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/account_management.so W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/autoresponder.so W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/arts_sound.so W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/sms.so W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/hints.so W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/dsp_sound.so W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/x11_docking.so W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/default_sms.so W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/ext_sound.so W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/encryption.so W: kadu no-documentation W: kadu-alsa_sound unstripped-binary-or-object /usr/lib64/kadu/modules/alsa_sound.so W: kadu-amarok unstripped-binary-or-object /usr/lib64/kadu/modules/amarok.so W: kadu-arts_sound unstripped-binary-or-object /usr/lib64/kadu/modules/arts_sound.so W: kadu-dcopexport unstripped-binary-or-object /usr/lib64/kadu/modules/dcopexport.so W: kadu-esd_sound unstripped-binary-or-object /usr/lib64/kadu/modules/esd_sound.so W: kadu-exec_notify unstripped-binary-or-object /usr/lib64/kadu/modules/exec_notify.so W: kadu-ext_info unstripped-binary-or-object /usr/lib64/kadu/modules/ext_info.so W: kadu-filedesc unstripped-binary-or-object /usr/lib64/kadu/modules/filedesc.so W: kadu-iwait4u unstripped-binary-or-object /usr/lib64/kadu/modules/iwait4u.so W: kadu-led_notify unstripped-binary-or-object /usr/lib64/kadu/modules/led_notify.so W: kadu-miastoplusa_sms unstripped-binary-or-object /usr/lib64/kadu/modules/miastoplusa_sms.so W: kadu-spellchecker unstripped-binary-or-object /usr/lib64/kadu/modules/spellchecker.so W: kadu-tabs unstripped-binary-or-object /usr/lib64/kadu/modules/tabs.so W: kadu-weather unstripped-binary-or-object /usr/lib64/kadu/modules/weather.so W: kadu-xmms unstripped-binary-or-object /usr/lib64/kadu/modules/xmms.so If you fix the above two issues this output will vanish and the package approved :) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
