Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: <Cherokee> Flexible WebServer Alias: Cherokee https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201149 ------- Additional Comments From [EMAIL PROTECTED] 2006-08-16 03:45 EST ------- (In reply to comment #8) > (In reply to comment #7) > > > > CFLAGS="$RPM_OPT_FLAGS" \ > > ./configure --prefix=%{_prefix} \ > > --sysconfdir=%{_sysconfdir} \ > > --mandir=%{_mandir} \ > > --sbindir=%{_sbindir} \ > > --with-wwwroot=/home/httpd/ \ > > --enable-pthreads > Any particular reason for not using %configure? > > Also, here you are not passing --includedir, nevertheless you are using it in > %files. > > > make CFLAGS="-O0 -g3" > Why this? Above you are exporting CFLAGS="$RPM_OPT_FLAGS", here you are > overriding it with something compatible again? > You're right, I've corrected it, here the spec file after those new points of view. Thank you very much, Ralf. %prep %setup -q %build CFLAGS="$RPM_OPT_FLAGS" \ %configure --prefix=%{_prefix} \ --sysconfdir=%{_sysconfdir} \ --mandir=%{_mandir} \ --sbindir=%{_sbindir} \ --with-wwwroot=/home/httpd/ \ --enable-pthreads #make CFLAGS="-O0 -g3" %install make install DESTDIR=$RPM_BUILD_ROOT #rm $RPM_BUILD_ROOT/etc/cherokee/sites-enabled/default %clean rm -rf $RPM_BUILD_ROOT %post /sbin/ldconfig ln -s %{_sysconfdir}/cherokee/sites-available/default \ %{_sysconfdir}/cherokee/sites-enabled/default mkdir -p /home/httpd %postun /sbin/ldconfig %files %{_mandir}/* %{_bindir}/* %{_libdir}/* %{_datadir}/* %{_sbindir}/* %{_includedir}/* %{_sysconfdir}/* /home/httpd/* %changelog *2006-08-16 Manuel Arostegui Ramirez <[EMAIL PROTECTED]> -Misc changes on spec file in order to make it much more polished. Thanks John and Ralf -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
