Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483187 Orcan 'oget' Ogetbil <oget.fed...@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oget.fed...@gmail.com --- Comment #1 from Orcan 'oget' Ogetbil <oget.fed...@gmail.com> 2009-02-01 01:31:14 EDT --- Here are my notes: ! rpmlint says: kde-plasma-weather.x86_64: W: no-documentation but there is really no documentation, so this can be ignored ? The package must be named according to the Package Naming Guidelines. Upstream webpage says: "For those looking for the weather forecast plasmoid (that's the official name of it), it's now..." So shall we call this package "kde-plasma-weatherforecast" instead? * please make use of the %{name} macro. * According to the guidelines http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages the pre-release packages are versioned in a special way. Check the "kismet" example given in the above link. So it would probably better to change Version: 0.0 Release: 0.2%{?dist}.20090130svn to Version: 0 Release: 0.2.20090130svn%{?dist} The right-hand side of the disttag is to be used when there is a fix in an older branch, e.g. F-9 * Isn't plasma-devel provided by kdelibs-devel which is one of the dependencies of kdebase-workspace-devel? So, that BR seems redundant. * Fedora-specific flag -fexceptions is overriden by -fno-exceptions but I think this is a problem with the compilation of kde itself. Can this be fixed? * Do we really need call ldconfig on post{,un} ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
