Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=505155 Tomas Mraz <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #11 from Tomas Mraz <[email protected]> 2009-06-11 15:23:12 EDT --- I have only two nitpicks: 1. the script to create the new symlink is overly complicated why not do it this way: rm -f $RPM_BUILD_ROOT/%{_lib}/%{name}.so mkdir -p $RPM_BUILD_ROOT/%{_libdir} VLIBNAME=$(ls $RPM_BUILD_ROOT/%{_lib}/%{name}.so.*.*.*) LIBNAME=$(basename $VLIBNAME) ln -s ../../%{_lib}/$LIBNAME $RPM_BUILD_ROOT/%{_libdir}/%{name}.so 2. there is unnecessary / before %{_libdir} on the symlink line in %files devel. The rpmlint is still silent: $ rpmlint -v libcap-ng-0.4.1-1.x86_64.rpm libcap-ng.x86_64: I: checking 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint -v libcap-ng-debuginfo-0.4.1-1.x86_64.rpm libcap-ng-debuginfo.x86_64: I: checking 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint -v libcap-ng-devel-0.4.1-1.x86_64.rpm libcap-ng-devel.x86_64: I: checking 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint -v libcap-ng-0.4.1-1.src.rpm libcap-ng.src: I: checking 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint -v libcap-ng-utils-0.4.1-1.x86_64.rpm libcap-ng-utils.x86_64: I: checking 1 packages and 0 specfiles checked; 0 errors, 0 warnings. The nitpicks are no showstoppers so the package is ACCEPTED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
