Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=512228 Ville Skyttä <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|[email protected] |[email protected] Flag| |fedora-review+ --- Comment #1 from Ville Skyttä <[email protected]> 2009-07-16 15:35:23 EDT --- Approved, just a couple of remarks: I'd personally use a patch for the BYTE -> char change, it's less fragile that way on future updates. sed -e 's/\r//g' %{SOURCE1} > dumpasn1.cfg This is no longer necessary, the 20090531 dumpasn1.cfg already has Unix line endings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
