Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=497622 --- Comment #29 from Tim Fenn <[email protected]> 2009-07-24 05:10:39 EDT --- (In reply to comment #28) > (In reply to comment #27) > > Adding --with-arpack enables building of a "driver" binary that is part of > > the > > tools folder, which is just copied to the share directory in the > > install-data-local macro, so its not required for APBS. Would it be best to > > set up a -tools subpackage with all the extras? (see here: > > http://cardon.wustl.edu/MediaWiki/index.php/An_overview_of_the_APBS_package#Other_tools_distributed_with_APBS > > for more info) And I'm also worried about having a binary just called > > "driver" > > lying around - could that be an issue? > > Yes, "driver" is a no-go and must be renamed to e.g. abps-driver if packaged. > If it is compiled, how is it installed in the share directory..? > its labeled as "noinst_PROGRAMS," but in the install-data-local script in the master Makefile.am, the *entire* tools subdirectory is manually copied to ${prefix}/share. > Actually, you'll have to rename everythin in the tools/ folder in the package. > > IMHO they should be packaged, since they are included in the abps > distribution. > sure, I'll prepend apbs- to all the binaries and put them in a -tools subpackage. > > Adding --enable-python doesn't do anything other than build ZSI (which it > > shouldn't do) - which I realized, python-ZSI should be a requires so > > ApbsClient.py runs properly. > > That's odd. After all > http://cardon.wustl.edu/MediaWiki/index.php/An_overview_of_the_APBS_package#Python_development_tools > Right, but main and noinput.py aren't handled by any of the build scripts (except for manually copying the entire tools subdir), and there are several other .py files in the tools/python folder, so I'm not sure what to include and/or where things should go. The tools/python/vgrid folder builds a noinst_PROGRAM called _vgrid.so (which I think should be compiled as a library?) and contains several .py files that might be useful, but again are left untouched by the build scripts... I think it would be best to just take the binaries that should obviously be included (such as the binaries in tools/mesh) and ask upstream about the more ambiguous stuff. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
