On Tue, Nov 05, 2013 at 10:55:01PM +0100, Anders Logg wrote: > On Tue, Nov 05, 2013 at 02:19:51PM +0000, Garth N. Wells wrote: > > On 2013-11-05 13:39, Anders Logg wrote: > > >On Thu, Oct 31, 2013 at 05:20:08PM +0000, Garth N. Wells wrote: > > >>On 2013-10-31 14:44, Johan Hake wrote: > > >>>On Thu, Oct 31, 2013 at 3:24 PM, Garth N. Wells <[email protected]> > > >>>wrote: > > >>> > > >>>>On 2013-10-31 14:15, Anders Logg wrote: > > >>>> > > >>>>>Great job! It's all green now. :-) > > >>>>> > > >>>>>Time for a release? > > >>>> > > >>>>Yes(!), > > >>> > > >>>Agree! > > >>> > > >>> > > >>>>but what do we do about the gcc/libstdc++ 4.8.1 bug in Ubuntu? It's > > >>>>not our bug but it does break the intersection code on Ubuntu 13.10. > > >>> > > >>> Is there an easy workaround in dolfin code? > > >> > > >>No. We could try using std::nth_element from Boost, but I think the > > >>interface is different and it's generating work for us when it > > >>should be fixed elsewhere. I've created an Ubuntu bug report: > > >> > > >>https://bugs.launchpad.net/ubuntu/+source/gcc-4.8/+bug/1246802 > > > > > >It was relatively easy to switch to the boost interface once I looked > > >closer at it so I will push a change which uses > > >boost::nth_element in place of std::nth_element. > > > > > > > Great. Leave plenty of comments so we can switch back again once the > > bug is fixed in Ubuntu (or much more likely, Ubuntu 14.04 arrives > > since Ubuntu doesn't seem to fix bugs). > > > > Garth > > It's easy to spot (a big #typedef at the top of GenericBoundingBoxTree.cpp). > > I have pushed it but not yet merged into next. One of the demos is > still failing for me (after switching to boost) so I need to check > into that.
Merged now into next. -- Anders _______________________________________________ fenics mailing list [email protected] http://fenicsproject.org/mailman/listinfo/fenics
