Re: [FFmpeg-devel] [PATCH 2/7] avutil/vulkan: automatically enable shader device address usage bit

[Lynne]

On 18/05/2025 21:11, Niklas Haas wrote:

From: Niklas Haas <g...@haasn.dev>

We require this internally when using descriptor buffers, so it makes sense
to enable it internally, also.
---
  libavutil/vulkan.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/libavutil/vulkan.c b/libavutil/vulkan.c
index 5f2ac6267d..97c008c809 100644
--- a/libavutil/vulkan.c
+++ b/libavutil/vulkan.c
@@ -989,6 +989,9 @@ int ff_vk_create_buf(FFVulkanContext *s, FFVkBuffer *buf, 
size_t size,
      int use_ded_mem;
      FFVulkanFunctions *vk = &s->vkfn;

+        usage |= VK_BUFFER_USAGE_SHADER_DEVICE_ADDRESS_BIT;

+ if (s->extensions & FF_VK_EXT_DESCRIPTOR_BUFFER)

You should omit the flag if the usage contains

VK_BUFFER_USAGE_VIDEO_DECODE_SRC_BIT_KHR or VK_BUFFER_USAGE_VIDEO_ENCODE_DST_BIT_KHR, since its not used there.

+
      VkBufferCreateInfo buf_spawn = {
          .sType       = VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO,
          .pNext       = pNext,

Apart from that, okay.

OpenPGP_0xA2FEA5F03F034464.asc
Description: OpenPGP public key

OpenPGP_signature.asc
Description: OpenPGP digital signature

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".