On Tue, Sep 02, 2014 at 11:26:13AM +0200, Deti Fliegl wrote: > On 30.08.14 01:22, Michael Niedermayer wrote: > >moving code from (like from decklink_enc.cpp to decklink_common.cpp) > >should be in a seperate patch > Done. Both patches are attached to this mail. > > >If you want to maintain this code, please add yourself to the > >MAINTAINERs file > Added. > > >non static functions should have a ff_ prefix (or av if they are > >public but that isnt) > Done, except for CreateDeckLinkIteratorInstance which is a function > that is part of the DeckLink Mac OS X & Linux API and which is not > available under Windows. So it has to be recoded to enable code > sharing between Mac OS X, Linux and Windows. > > >also i dont really know windows & decklink stuff, so iam not the > >ideal one to review ... > Well basically it all should be the same. It compiles and works > under Windows too, but most people would use the direct show input > support of ffmpeg for capturing from a DeckLink device. > > Deti
> MAINTAINERS | 1 > configure | 4 > doc/indevs.texi | 54 ++++ > libavdevice/Makefile | 3 > libavdevice/alldevices.c | 2 > libavdevice/decklink_dec.cpp | 531 > +++++++++++++++++++++++++++++++++++++++++++ > libavdevice/decklink_dec.h | 32 ++ > libavdevice/decklink_dec_c.c | 54 ++++ > 8 files changed, 678 insertions(+), 3 deletions(-) > 29ede1442e464e442821d730b05027063556fd45 > 0002-add-decklink-input-support-add-Maintainer-for-deckli.patch > Signed-off-by: Deti fliegl <d...@fliegl.de> patches applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many that live deserve death. And some that die deserve life. Can you give it to them? Then do not be too eager to deal out death in judgement. For even the very wise cannot see all ends. -- Gandalf
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
