Quoting Nicolas George (2023-01-20 21:47:16) > Anton Khirnov (12023-01-20): > > --- > > libavfilter/graphparser.c | 537 +++++++++----------------------------- > > 1 file changed, 126 insertions(+), 411 deletions(-) > > I notice you removed the "RFC" from the subject line,
That means I now consider the code to be ready for a full review rather than just comments on the overall approach. > By the way, I am baffled that you would write a 30k+ patch on code you > do not maintain Does the graphparser have a maintainer? I did not notice. $ grep graphparser MAINTAINERS $ > and do not know well without consulting the maintainer > who knows it. Maybe it's the person who authored the most commits touching that file recently $ git shortlog -ns --since=2012 --no-merges origin/master libavfilter/graphparser.c 16 Anton Khirnov 8 Michael Niedermayer 4 Andreas Rheinhardt Or maybe we should consider avfilter.h too, since I'm adding new API $ git shortlog -ns --since=2012 --no-merges origin/master libavfilter/graphparser.c libavfilter/avfilter.h 73 Anton Khirnov 32 Nicolas George 23 Stefano Sabatini Hmm, now who could possibly be the person who knows that code? Any guesses? -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
