>-----Original Message----- >From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> On Behalf Of James >Almer >Sent: Thursday, December 21, 2023 8:47 PM >To: ffmpeg-devel@ffmpeg.org >Subject: Re: [FFmpeg-devel] [PATCH 3/3] avutil/hwcontext_d3d12va: remove >unused variables > >On 12/21/2023 9:42 AM, Martin Storsjö wrote: >> On Thu, 21 Dec 2023, James Almer wrote: >> >>> Removes -Wunused-variable warnings. >>> >>> Signed-off-by: James Almer <jamr...@gmail.com> >>> --- >>> Were this meant to be used? Or are just a remnant of a previous >>> interation of >>> the set?
They are just leftovers of the previous version. Patch set LGTM, thanks. >>> >>> libavutil/hwcontext_d3d12va.c | 4 ---- >>> 1 file changed, 4 deletions(-) >>> >>> diff --git a/libavutil/hwcontext_d3d12va.c >>> b/libavutil/hwcontext_d3d12va.c >>> index 4ce29f250c..46832fd19b 100644 >>> --- a/libavutil/hwcontext_d3d12va.c >>> +++ b/libavutil/hwcontext_d3d12va.c >>> @@ -173,7 +173,6 @@ fail: >>> >>> static void d3d12va_frames_uninit(AVHWFramesContext *ctx) >>> { >>> - AVD3D12VAFramesContext *frames_hwctx = ctx->hwctx; >>> D3D12VAFramesContext *s = ctx->internal->priv; >> >> Here, I'd prefer to get rid of the extra spaces once the other line, >> which it was aligned to, is gone. >> >>> static int d3d12va_frames_init(AVHWFramesContext *ctx) >>> { >>> AVD3D12VAFramesContext *hwctx = ctx->hwctx; >>> - AVD3D12VADeviceContext *device_hwctx = ctx->device_ctx->hwctx; >>> - D3D12VAFramesContext *s = ctx->internal->priv; >> >> Ditto > >Amended locally. Thanks. >_______________________________________________ >ffmpeg-devel mailing list >ffmpeg-devel@ffmpeg.org >https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >To unsubscribe, visit link above, or email >ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".