On 9/17/2025 8:32 PM, Marton Balint via ffmpeg-devel wrote:
On Wed, 17 Sep 2025, Timo Rothenpieler via ffmpeg-devel wrote:On 9/16/2025 11:12 PM, Balint Marton via ffmpeg-devel wrote:- I am not sure what would be the counterpart of doing a last-chance ping before applying a series in the foregejo system, it was a useful thing in the ML workflow. Maybe some "auto-apply this in 1 day even if there are no approvals" checkbox with mail notificaitons could work, and thatwould also resolve the issue of self-approval.That's not an option, but could be emulated with CI to some extend.But generally if someone wants to insta-merge a PR, they can. Given they could just push it manually.Yeah, I know I can always push manually, it just more work than pressing a simple button on the web UI. Also notifying the others that I intend to push something soon (even if there are no approvals) is a feature which we now miss.
You can still just comment that in the same way you do with a mail. And it's how it's already being done on multiple PRs.
- Bumping versions and final commit polishing is a bit tiresome withforegjo. E.g. it would be nice if I could also edit the commit message,not just the commit title in the web page...I'm not entirely sure what you're referring to here. Editing commit messages via Web UI? Where do you ever do that?When applying other people's work, it is quite common that the patch is good but the commit message is bad. It is less work for me to reword the commit message (and apply the patch) instead of describing what need to be changed. Yeah, I could pull the branch, fix the commit message, force push it, and apply, but that is cumbersome... Forgejo already has the ability to edit commit message title, so editing the commit message as well should not be too hard.
Does it? You can edit the PR title, but with the rebase based merged we do, that has no impact on the commit messaged.
It'd only be used in a squash merge. Or am I missing a feature somewhere?
- Pull requests show up on the mailing list but not force pushes, so people only reading patches via email won't get notifications of new versions.That's an intentional decision. I could send mails for every single thing that happens in a PR, but I opted not to to not completely flood the ML.Force pushes to pull requests are like patch v2 / v3, etc. If we send the original pull request as a patch to the ML, we should also send updated patches to the ML.
The problem is they can be very frequent. And not only force pushes.So the current implementation is a compromise between visibility and spam-level.
smime.p7s
Description: S/MIME Cryptographic Signature
_______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-le...@ffmpeg.org
