PR #24491 opened by michaelni
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/24491
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/24491.patch

Fixes: out of array read
Fixes: MPROjGMydv4r
Found-by: zhang xingxing

Signed-off-by: Michael Niedermayer <[email protected]>



>From c66dd06efd2e98368eea82faa130964a41a345ab Mon Sep 17 00:00:00 2001
From: Michael Niedermayer <[email protected]>
Date: Mon, 14 Sep 2026 18:57:09 +0200
Subject: [PATCH] avfilter/af_chorus: reject any mismatch between the delays,
 decays, speeds and depths counts

Fixes: out of array read
Fixes: MPROjGMydv4r
Found-by: zhang xingxing

Signed-off-by: Michael Niedermayer <[email protected]>
---
 libavfilter/af_chorus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavfilter/af_chorus.c b/libavfilter/af_chorus.c
index f7eeea3a23..7f1e1e2c6b 100644
--- a/libavfilter/af_chorus.c
+++ b/libavfilter/af_chorus.c
@@ -132,7 +132,7 @@ static av_cold int init(AVFilterContext *ctx)
     fill_items(s->speeds_str, &nb_speeds, s->speeds);
     fill_items(s->depths_str, &nb_depths, s->depths);
 
-    if (nb_delays != nb_decays && nb_delays != nb_speeds && nb_delays != 
nb_depths) {
+    if (nb_delays != nb_decays || nb_delays != nb_speeds || nb_delays != 
nb_depths) {
         av_log(ctx, AV_LOG_ERROR, "Number of delays & decays & speeds & depths 
given must be same.\n");
         return AVERROR(EINVAL);
     }
-- 
2.52.0

_______________________________________________
ffmpeg-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to